[SOLVED][Bug Population] res_xxxxxxxxxxxx

rlff38 wrote:Why some residences have 0 population ? For res_italian_oldapts, the min population is 350/680 (in gamesettings.xml)

[You must be registered and logged in to see this image.]

The currentPopulation in database is stored at 0.

After manually collecting, I get +60 for 2 of them and now the bot show :

[You must be registered and logged in to see this image.]

Code:

    function GetResidencesBasePopulation($name) {
        foreach ($this->gsXML->items->item as $item) {
            if ($item['name'] == $name) {
                if (!isset($item->populationBase)) {
                    $res = $this->GetResidencesBasePopulation( (string)$item['derivesFrom'] ); //recursive callback
                    break;
                }
                $res = (string)$item->populationBase;
                break;
            }
        }
        return $res;
    }

rlff38 wrote:Thx Todd

I think a new method xmlsOb::GetResidencesBasePopulation($name) will be welcome in ./codebase-php/GetSettingsFromXml.php

maybe this one :

Code:

    function GetResidencesBasePopulation($name) {
        foreach ($this->gsXML->items->item as $item) {
            if ($item['name'] == $name) {
                if (!isset($item->populationBase)) {
                    $res = $this->GetResidencesBasePopulation( (string)$item['derivesFrom'] ); //recursive callback
                    break;
                }
                $res = (string)$item->populationBase;
                break;
            }
        }
        return $res;
    }

Tested and works perfectly

Little Todd wrote:Yes, that function is required in GetSettingsFromXml.php, but a call to that function is needed in the buildings class file. Did you edit the class file also?

Code:

        foreach ($resI as $id=>$item)
        {
            $obj = $this->ld->GetObjectById($id);
            $pop = $obj["currentPopulation"]*10;
            // -- [START] -- ADDED FOR BUG POPULATION
            if($pop == 0)
                $pop = $xmlsOb->GetResidencesBasePopulation($item)*10;
            // -- [END] -- ADDED FOR BUG POPULATION
            $popmax = $xmlsOb->GetResidencesMaxPopulation($item)*10;
            $popstats = $pop." / ".$popmax;
            if ($popmax - $pop == 0) {$full = "(FULL) ";} else {$full = "";}
            $resIN .= '<option value="'.$id.'">'.$full.$item." ($id) : $popstats</option>";
        }
        foreach ($resN as $id=>$item)
        {
            $obj = $this->ld->GetObjectById($id);
            $pop = $obj["currentPopulation"]*10;
            // -- [START] -- ADDED FOR BUG POPULATION
            if($pop == 0)
                $pop = $xmlsOb->GetResidencesBasePopulation($item)*10; //
            // -- [END] -- ADDED FOR BUG POPULATION
            $popmax = $xmlsOb->GetResidencesMaxPopulation($item)*10;
            $popstats = $pop." / ".$popmax;
            if ($popmax - $pop == 0) {$full = "(FULL) ";} else {$full = "";}
            $resNOT .= '<option value="'.$id.'">'.$full.$item." ($id) : $popstats</option>";
        }

Code:

      foreach ($resI as $id=>$item)
      {
      $obj = $this->ld->GetDTObjectById($id);
      $pop = $obj["currentPopulation"]*10;
        // -- [START] -- ADDED FOR BUG POPULATION
            if($pop == 0)
                $pop = $xmlsOb->GetResidencesBasePopulation($item)*10;
        // -- [END] -- ADDED FOR BUG POPULATION
      $popmax = $xmlsOb->GetResidencesMaxPopulation($item)*10;
      $popstats = $pop." / ".$popmax;
      if ($popmax - $pop == 0) {$full = "(FULL) ";} else {$full = "";}
        $resIN .= '<option value="'.$id.'">'.$full.$item." ($id) : $popstats</option>";
      }
      foreach ($resN as $id=>$item)
      {
      $obj = $this->ld->GetDTObjectById($id);
      $pop = $obj["currentPopulation"]*10;
        // -- [START] -- ADDED FOR BUG POPULATION
            if($pop == 0)
                $pop = $xmlsOb->GetResidencesBasePopulation($item)*10;
        // -- [END] -- ADDED FOR BUG POPULATION
      $popmax = $xmlsOb->GetResidencesMaxPopulation($item)*10;
      $popstats = $pop." / ".$popmax;
      if ($popmax - $pop == 0) {$full = "(FULL) ";} else {$full = "";}
        $resNOT .= '<option value="'.$id.'">'.$full.$item." ($id) : $popstats</option>";
      }

blwilli12 wrote:This fixes the residents in the boxes but not the custom houses and the skyscrapers

Little Todd wrote:

blwilli12 wrote:This fixes the residents in the boxes but not the custom houses and the skyscrapers

Can you post a screen shot of the bot and one of the item in game showing the difference?

Thanks.

blwilli12 wrote:

Little Todd wrote:

blwilli12 wrote:This fixes the residents in the boxes but not the custom houses and the skyscrapers

Can you post a screen shot of the bot and one of the item in game showing the difference?

Thanks.

[You must be registered and logged in to see this image.]



the wintercastle without the fix gave a 0 pop and with the fix the pop is show right as in the pic above but as you can see the second custom house and the japanese skyscraper is showing 0 pop as seen in the pic above. The pic shows the building in question are shown bellow.

[You must be registered and logged in to see this image.]

Code:

$pop = $obj['currentPopulation']*10;

Code:

if ($pop == 0) {$pop = $this->xmlsOb->GetResidencesBasePopulation($obj['itemName'])*10;}

Code:

$pop = $obj['currentPopulation']*10;

Code:

if ($pop == 0) {$pop = $this->xmlsOb->GetResidencesBasePopulation($obj['itemName'])*10;}

blwilli12 wrote:got this error when putting line of code in for the skyscrapers

Fatal error: Call to a member function GetResidencesBasePopulation() on a non-object in C:\Program Files (x86)\CVBot - Project DEVIL\Plugins\Buildings\Buildings_class.php on line 562

Code:

if($pop == 0) {$pop = $xmlsOb->GetResidencesBasePopulation($obj['itemName'])*10;}

blwilli12 wrote:ok that line of code fix the problem.

Thank you

P.S the custom houses and skyscraper collection is only on the buildings plugin after the 1.5.6 update